--- smsdaemon/TaskManager.cpp 2008/12/07 20:58:41 149 +++ smsdaemon/TaskManager.cpp 2008/12/18 06:53:29 196 @@ -1,7 +1,7 @@ - + #include "TaskManager.h" -#include "common.h" +#include "Logger.h" #include @@ -9,12 +9,12 @@ TaskManager::TaskManager() - : _lastExecuted(0) + : _lastExecuted(0) { } - + TaskManager::~TaskManager() -{ +{ //delete any temporary tasks still in the list std::list::iterator it; for (it = _temp_tasks.begin(); it != _temp_tasks.end(); ++it) @@ -29,19 +29,18 @@ static SpoolTask task; //print the loaded tasks - std::map::iterator it; - for(it = _persistant_tasks.begin(); it != _persistant_tasks.end(); ++it) + std::map::iterator it; + for (it = _persistant_tasks.begin(); it != _persistant_tasks.end(); ++it) { Task* tsk = (*it).second; if (tsk != 0) - Common::instance()->logMessage( std::string("Loaded task \"") + tsk->GetName() + "\"" ); + Logger::logMessage( std::string("Loaded task \"") + tsk->GetName() + "\"" ); } } void TaskManager::AddPersistantTask(Task* task) { - Common* cmn = Common::instance(); if (task != 0) { @@ -50,11 +49,11 @@ if ( _persistant_tasks[ name ] == 0) _persistant_tasks[ name ] = task; else - cmn->logMessage( std::string("AddTask() -- already have a task called ") + name); + Logger::logMessage( std::string("AddTask() -- already have a task called ") + name); } else { - cmn->logMessage("AddTask() -- cannot register a null pointer"); + Logger::logMessage("AddTask() -- cannot register a null pointer"); } } @@ -66,10 +65,10 @@ void TaskManager::ExecuteTasks(ISmsTransceiver& modem) { - const int SLEEP_TIME = 10; //wait at least 10 seconds between executions + const int SLEEP_TIME = 2; //wait this long between task executions int now = time(0); - if (now < (_lastExecuted + SLEEP_TIME) ) + if (now < (_lastExecuted + SLEEP_TIME) ) return; _lastExecuted = now; @@ -95,11 +94,11 @@ if ( tsk->IsFinished() ) { delete tsk; - l_it = _temp_tasks.erase(l_it); - + l_it = _temp_tasks.erase(l_it); + //now l_it points to the next element in the list, //but since the for() loop will increment it before next iteration we will decrease it here - --l_it; + --l_it; } }