--- dao/DaoAdresseVedligehold/src/main/java/dk/daoas/adressevedligehold/dawa/DawaTask.java 2016/04/19 15:49:14 3006 +++ dao/DaoAdresseVedligehold/src/main/java/dk/daoas/adressevedligehold/dawa/DawaTask.java 2016/05/02 08:00:47 3034 @@ -3,9 +3,7 @@ import java.util.ArrayList; import java.util.List; import java.util.Map; -import java.util.Set; import java.util.TreeMap; -import java.util.TreeSet; import dk.daoas.adressevedligehold.MailSender; import dk.daoas.adressevedligehold.beans.Address; @@ -13,6 +11,7 @@ import dk.daoas.adressevedligehold.db.DatabaseCoverageUpdate; import dk.daoas.adressevedligehold.tasks.Task; import dk.daoas.adressevedligehold.tasks.TaskLogger; +import dk.daoas.adressevedligehold.util.CountMap; import dk.daoas.adressevedligehold.util.DeduplicateHelper; import dk.daoas.adressevedligehold.util.TimingHelper; @@ -24,18 +23,21 @@ public class DawaTask extends Task { - final String kommentarTemplate = "Oprettet via DAWA"; + final static String KOMMENTAR_TEMPLATE = "Oprettet via DAWA"; private TaskLogger logger = TaskLogger.getInstance(); private short regionCode; private String regionName; + int antalBehandlede = 0; + int antalKommuner = 0; - DatabaseCoverageUpdate db = new DatabaseCoverageUpdate(); + DeduplicateHelper dedup = new DeduplicateHelper<>(); - DeduplicateHelper dedup = new DeduplicateHelper<>(); + + public DawaTask(short regionCode, String regionName){ this.regionCode = regionCode; @@ -46,7 +48,9 @@ @Override protected void taskRun() throws Exception { TimingHelper timer = new TimingHelper(); - + + DatabaseCoverageUpdate db = new DatabaseCoverageUpdate(); + DawaWebservice dawa = new DawaWebservice(); TreeMap search = new TreeMap<>(); @@ -72,16 +76,18 @@ Map kommuner = dawa.kommunerIRegion(regionCode); - String subject = "DAWA indlæsning done"; + String subject = "DAWA indlæsning - " + regionName; StringBuilder headerSB = new StringBuilder(); - headerSB.append("

Indlæsnings rapport for " + regionName + " / " + regionCode + "


"); + headerSB.append("

Indlæsnings rapport for " + regionName + "


"); int totalAntalNye = 0; int totalAntalFejl = 0; int totalAntalUkendt = 0; int totalAntalDobbelt = 0; + antalKommuner = kommuner.size(); + StringBuilder sb = new StringBuilder(); @@ -94,20 +100,23 @@ List
dawaListe = dawa.adresserIKommune(kommunekode); // stage 3 søg - Set ukendteDAV = new TreeSet<>(); - Set dobbeltGadeidDAV = new TreeSet<>(); + CountMap ukendteDAV = new CountMap(); + CountMap dobbeltGadeidDAV = new CountMap(); List
nyeAdresser = new ArrayList<>(); for (Address dawaAddr : dawaListe) { String dav = getDAVid(dawaAddr); DawaGade gade = search.get(dav); if (gade == null) { - ukendteDAV.add(dav + " " + dawaAddr.vejnavn); + String key = dav + " " + dawaAddr.vejnavn; + ukendteDAV.increment(key); continue; } if (gade.gadeids.size() != 1) { - dobbeltGadeidDAV.add(dav + " " + dawaAddr.vejnavn); + String key = dav + " " + dawaAddr.vejnavn; + dobbeltGadeidDAV.increment(key); + continue; } boolean fundet = false; @@ -121,7 +130,7 @@ if (fundet == false) { dawaAddr.gadeid = gade.gadeids.iterator().next(); dawaAddr.state = AddressState.CREATED; - dawaAddr.kommentar = kommentarTemplate; + dawaAddr.kommentar = KOMMENTAR_TEMPLATE; nyeAdresser.add(dawaAddr); } } @@ -129,7 +138,7 @@ db.saveNewAddresses(nyeAdresser); - logger.info("Save to db done - sending report mail"); + logger.info("Save to db done - adding to report mail"); List
saveOK = new ArrayList<>(); List
saveFail = new ArrayList<>(); @@ -145,9 +154,14 @@ totalAntalFejl += saveFail.size(); totalAntalUkendt += ukendteDAV.size(); totalAntalDobbelt += dobbeltGadeidDAV.size(); + + + antalBehandlede++; - sb.append("

Kommune: " + kommunenavn + " / " + kommunekode + "


\n"); + sb.append("

Kommune: " + kommunenavn + "

\n"); + + sb.append("Kommunekode: " + kommunekode + "
\n"); sb.append("Antal Inserts: " + saveOK.size() + "
\n"); sb.append("Antal insert fails: " + saveFail.size() + "
\n"); sb.append("Antal ukendte dav: " + ukendteDAV.size() + "
\n"); @@ -160,16 +174,16 @@ addressTable(sb, saveFail); sb.append("

Ukendte DAV:

\n"); - for (String dav : ukendteDAV) { - sb.append(dav + "
\n"); + for (Map.Entry dav : ukendteDAV.entrySet()) { + sb.append(dav.getKey() + " : " + dav.getValue() + "
\n"); } sb.append("

Dobbelt gadeid DAV:

\n"); - for (String dav : dobbeltGadeidDAV) { - sb.append(dav + "
\n"); - } - + for (Map.Entry dav : dobbeltGadeidDAV.entrySet()) { + sb.append(dav.getKey() + " : " + dav.getValue() + "
\n"); + } } + logger.info("Sendingreport mail"); headerSB.append("Antal Inserts: " + totalAntalNye + "
\n"); headerSB.append("Antal insert fails: " + totalAntalFejl + "
\n"); @@ -179,6 +193,9 @@ MailSender.sendMail(subject, headerSB.toString() + sb.toString() ); + + //Cleaning + dedup.clear(); } private void addressTable(StringBuilder sb, List
addr) { @@ -216,7 +233,12 @@ @Override public double getPercentCompleted() { - return 0; + if (antalKommuner == 0) { + return 0; + } + + return (antalBehandlede / ((double)antalKommuner) ) * 100.0; + }