--- android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/TimetableServlet.java 2009/10/08 12:19:42 421 +++ android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/TimetableServlet.java 2010/05/03 07:42:02 697 @@ -10,7 +10,7 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; -import dk.thoerup.curcuitbreaker.CircuitBreakerException; +import dk.thoerup.circuitbreaker.CircuitBreakerException; /** * Servlet implementation class TimetableServlet @@ -21,19 +21,42 @@ Logger logger = Logger.getLogger( TimetableServlet.class.getName() ); - TimetableFetcher fetcher = new TimetableFetcher(); + TimetableFetcher fetcher; + @Override + public void init() throws ServletException { + super.init(); + + boolean useTempSite = Boolean.parseBoolean( getServletContext().getInitParameter("usetempsite") ); + int cacheTimeout = Integer.parseInt( getServletContext().getInitParameter("cache_timeout") ); + logger.info( "TimetableServlet, use temp site=" + useTempSite + ", cache=" + cacheTimeout); + fetcher = new TimetableFetcher(useTempSite,cacheTimeout); + } + + @Override protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { + if (request.getParameter("train") == null) { + response.sendError(400, "not enough parameters"); + return; + } + String train = request.getParameter("train").trim(); + String trainID; + String type = request.getParameter("type"); - String sections[] = train.split(" "); - if (sections.length != 2) { - response.sendError(400, "Invalid parameter"); - return; + if (type != null) { + trainID = train; + } else { //remove this failover sometime after release of client 0.6.4 + String sections[] = train.split(" "); + if (sections.length != 2) { + response.sendError(400, "Invalid parameter"); + return; + } + + type = lookupType(sections[0]); + trainID = sections[1]; } - String type = lookupType(sections[0]); - String trainID = sections[1]; try { List timetable = fetcher.cachedLookupTimetable(trainID, type); @@ -42,19 +65,19 @@ response.setContentType("text/xml"); response.getWriter().print(responseXML); - } catch (java.net.SocketTimeoutException ste) { - logger.warning("(timetable) Read timed out, train="+train); + } catch (java.io.IOException ioe) { + logger.warning("(timetable) Read failed, train="+train + ". " + ioe.getMessage()); response.sendError(500, "Backend timed out"); } catch (CircuitBreakerException cbe) { logger.warning("Circuitbreaker - failing fast"); response.sendError(500); - }catch (Throwable e) { + }catch (Exception e) { logger.log(Level.WARNING, "failure looking up timetable: train=" +train, e); response.sendError(500); } } - + /*remove /outcomment/deprecate after 0.6.4 release */ String lookupType(String trainCode) { trainCode = trainCode.toLowerCase();