--- android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureServlet.java 2009/09/10 18:11:53 307 +++ android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureServlet.java 2010/06/10 22:26:09 829 @@ -1,10 +1,9 @@ package dk.thoerup.traininfoservice.banedk; import java.io.IOException; -import java.sql.Connection; -import java.sql.ResultSet; -import java.sql.Statement; import java.util.List; +import java.util.logging.Level; +import java.util.logging.Logger; import javax.servlet.ServletException; import javax.servlet.http.HttpServlet; @@ -22,31 +21,71 @@ import org.w3c.dom.Document; import org.w3c.dom.Element; -import dk.thoerup.traininfoservice.DBConnection; +import dk.thoerup.circuitbreaker.CircuitBreakerException; +import dk.thoerup.traininfoservice.StationDAO; +import dk.thoerup.traininfoservice.Statistics; /** * Servlet implementation class DepartureServlet */ public class DepartureServlet extends HttpServlet { private static final long serialVersionUID = 1L; + + Logger logger = Logger.getLogger( DepartureServlet.class.getName() ); - DepartureFetcher fetcher = new DepartureFetcher(); + DepartureFetcher fetcher; TransformerFactory transformerFactory = TransformerFactory.newInstance(); DocumentBuilderFactory docBuilderFactory = DocumentBuilderFactory.newInstance(); - protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { + @Override + public void init() throws ServletException { + super.init(); + + boolean useTempSite = Boolean.parseBoolean( getServletContext().getInitParameter("usetempsite") ); + int cacheTimeout = Integer.parseInt( getServletContext().getInitParameter("cache_timeout") ); + logger.info( "DepartureServlet, use temp site=" + useTempSite + ", cache=" + cacheTimeout); + fetcher = new DepartureFetcher(useTempSite, cacheTimeout); + } + + @Override + protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { + if (req.getParameter("station") == null) { + resp.sendError(400, "not enough parameters"); + return; + } + + boolean arrival = false; + try { + arrival = Integer.parseInt( req.getParameter("arrival")) != 0; + } catch (Exception e) {} + + Statistics.getInstance().incrementDepartureLookups(); + int station = Integer.parseInt( req.getParameter("station") ); String format = req.getParameter("format"); List beans; - String stationName = getStationName(station); + String stationName = StationDAO.getStationName(station); try { - beans = fetcher.lookupDepartures(station); - } catch (Exception e) { - throw new ServletException(e); + beans = fetcher.cachedLookupDepartures(station, arrival); + } catch (java.io.IOException ioe) { + logger.warning("Read failed, station="+station + ". " + ioe.getMessage() ); + Statistics.getInstance().incrementDepartureErrors(); + resp.sendError(500); + return; + } catch (CircuitBreakerException cbe) { + logger.warning("Circuitbreaker - failing fast"); + Statistics.getInstance().incrementDepartureErrors(); + resp.sendError(500); + return; + } catch (Exception e) { + logger.log(Level.WARNING, "Unknown exception, station=" +station, e); + Statistics.getInstance().incrementDepartureErrors(); + resp.sendError(500); + return; } resp.setDateHeader("Expires", 0); @@ -56,6 +95,11 @@ resp.setContentType("text/xml"); resp.getWriter().print( formatXml(beans, stationName) ); } else if (format.equalsIgnoreCase("html")) { + + String advStr = req.getParameter("advanced"); + boolean advanced = advStr != null ? Boolean.parseBoolean(advStr) : false; + + req.setAttribute("advanced", advanced); req.setAttribute("stationname", stationName ); req.setAttribute("departurebeans", beans); req.setAttribute("stationID", station ); @@ -111,6 +155,10 @@ note.setTextContent( departure.getNote() ); train.appendChild(note); + Element type = doc.createElement("type"); + type.setTextContent( departure.getType() ); + train.appendChild(type); + root.appendChild(train); } @@ -137,27 +185,4 @@ return xml; } - protected String getStationName(int stationID) { - String station = ""; - - Connection conn = null; - try { - conn = DBConnection.getConnection(); - Statement stmt = conn.createStatement(); - ResultSet rs = stmt.executeQuery("SELECT name FROM trainstations WHERE id=" + stationID); - if (rs.next()) { - station = rs.getString(1); - } - - } catch (Exception e) { - } finally { - try { - if (conn != null && !conn.isClosed()) - conn.close(); - } catch (Exception e) {} - } - - return station; - } - }