--- android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureServlet.java 2010/09/16 19:14:47 1075 +++ android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureServlet.java 2011/04/19 11:52:39 1303 @@ -1,9 +1,7 @@ package dk.thoerup.traininfoservice.banedk; -import java.io.ByteArrayInputStream; -import java.io.ByteArrayOutputStream; -import java.io.File; import java.io.IOException; +import java.io.StringWriter; import java.util.logging.Level; import java.util.logging.Logger; @@ -12,12 +10,8 @@ import javax.servlet.http.HttpServlet; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; - -import javax.xml.transform.Source; -import javax.xml.transform.Transformer; +import javax.xml.transform.Templates; import javax.xml.transform.TransformerFactory; -import javax.xml.transform.stream.StreamResult; -import javax.xml.transform.stream.StreamSource; import org.simpleframework.xml.Serializer; import org.simpleframework.xml.core.Persister; @@ -25,6 +19,9 @@ import dk.thoerup.android.traininfo.common.DepartureBean; import dk.thoerup.circuitbreaker.CircuitBreakerException; import dk.thoerup.traininfoservice.Statistics; +import dk.thoerup.traininfoservice.TraininfoSettings; +import dk.thoerup.traininfoservice.banedk.DepartureFetcher.FetchTrainType; +import dk.thoerup.traininfoservice.db.StationDAO; /** * Servlet implementation class DepartureServlet @@ -39,28 +36,41 @@ - String xslPath; + TransformerFactory xslTransFact; + Templates xslTemplate; @Override public void init() throws ServletException { super.init(); - boolean useAzureSite = Boolean.parseBoolean( getServletContext().getInitParameter("useazuresite") ); - int cacheTimeout = Integer.parseInt( getServletContext().getInitParameter("cache_timeout") ); - int replyTimeout = Integer.parseInt( getServletContext().getInitParameter("reply_timeout") ); - logger.info( "DepartureServlet, use azure site=" + useAzureSite + ", cache=" + cacheTimeout); - fetcher = new DepartureFetcher(useAzureSite, cacheTimeout, replyTimeout); + + TraininfoSettings settings = (TraininfoSettings) getServletContext().getAttribute("settings"); + fetcher = new DepartureFetcher(settings); + + /* + xslTransFact = TransformerFactory.newInstance(); - xslPath = getServletContext().getRealPath("/departures.xsl"); + String xslPath = getServletContext().getRealPath("/departures.xsl"); + Source stylesheet = new StreamSource( new File(xslPath) ); + + try { + xslTemplate = xslTransFact.newTemplates(stylesheet); + } catch (Exception e) { + throw new ServletException(e); + }*/ } @Override protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { if (req.getParameter("station") == null) { - resp.sendError(400, "not enough parameters"); + resp.sendError(400, "not enough parameters (station)"); return; } + if (req.getParameter("format") == null) { + resp.sendError(400, "not enough parameters (format)"); + return; + } boolean arrival = false; try { @@ -72,10 +82,15 @@ int station = Integer.parseInt( req.getParameter("station") ); String format = req.getParameter("format"); - DepartureBean beans; + DepartureBean beans; + + DepartureFetcher.FetchTrainType type = FetchTrainType.BOTH; + if ( req.getParameter("type") != null) { + type = FetchTrainType.valueOf( req.getParameter("type") ); + } try { - beans = fetcher.cachedLookupDepartures(station, arrival); + beans = fetcher.cachedLookupDepartures(station, arrival, type); beans.arrival = arrival; } catch (java.io.IOException ioe) { logger.warning("Read failed, station="+station + ". " + ioe.getMessage() ); @@ -83,10 +98,15 @@ resp.sendError(500); return; } catch (CircuitBreakerException cbe) { - logger.warning("Circuitbreaker - failing fast"); + logger.warning("Circuitbreaker - failing fast, station=" +station); Statistics.getInstance().incrementDepartureErrors(); resp.sendError(500); return; + } catch (StationDAO.NostationException nse) { + logger.log(Level.WARNING, "Station not in Database, station=" +station); + Statistics.getInstance().incrementDepartureErrors(); + resp.sendError(400, "invalid station ID"); + return; } catch (Exception e) { logger.log(Level.WARNING, "Unknown exception, station=" +station, e); Statistics.getInstance().incrementDepartureErrors(); @@ -101,16 +121,16 @@ resp.setContentType("text/xml"); resp.getWriter().print( formatXml(beans) ); } else if (format.equalsIgnoreCase("html")) { - /* + String advStr = req.getParameter("advanced"); boolean advanced = advStr != null ? Boolean.parseBoolean(advStr) : false; req.setAttribute("advanced", advanced); req.setAttribute("departurebeans", beans); req.setAttribute("stationID", station ); - getServletContext().getRequestDispatcher("/ViewDepartures.jsp").forward(req,resp);*/ - resp.setContentType("text/html"); - resp.getWriter().print( xmlToHtml(formatXml(beans)) ); + getServletContext().getRequestDispatcher("/ViewDepartures.jsp").forward(req,resp); + /*resp.setContentType("text/html"); + resp.getWriter().print( xmlToHtml(formatXml(beans)) );*/ } else { resp.sendError(400, "Unknown format"); } @@ -121,7 +141,7 @@ Serializer serializer = new Persister(); - ByteArrayOutputStream out = new ByteArrayOutputStream(); + StringWriter out = new StringWriter(); try { serializer.write(beans, out); @@ -131,25 +151,21 @@ return out.toString(); } - - protected String xmlToHtml(String input) { + /* + protected String xmlToHtml(String input) throws ServletException { - try { - Source stylesheet = new StreamSource( new File(xslPath) ); - - - TransformerFactory transFact = TransformerFactory.newInstance(); - - Transformer trans = transFact.newTransformer(stylesheet); + try { + Transformer trans = xslTemplate.newTransformer(); + - Source xml = new StreamSource( new ByteArrayInputStream(input.getBytes() )); - ByteArrayOutputStream out = new ByteArrayOutputStream(); + Source xml = new StreamSource( new StringReader(input)); + StringWriter out = new StringWriter(); trans.transform(xml, new StreamResult(out)); return out.toString(); } catch (Exception e) { - return e.toString(); + throw new ServletException(e); } - } + }*/ }