--- android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureFetcher.java	2009/09/10 18:13:52	308
+++ android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureFetcher.java	2009/10/09 08:52:37	428
@@ -6,18 +6,41 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
+import java.util.Map;
+import java.util.logging.Logger;
 
 import com.gargoylesoftware.htmlunit.WebClient;
 import com.gargoylesoftware.htmlunit.html.DomNodeList;
 import com.gargoylesoftware.htmlunit.html.HtmlElement;
 import com.gargoylesoftware.htmlunit.html.HtmlPage;
 
+import dk.thoerup.curcuitbreaker.CircuitBreaker;
+import dk.thoerup.curcuitbreaker.CircuitBreakerManager;
 import dk.thoerup.traininfoservice.DBConnection;
 
 public class DepartureFetcher {
+	
+	Logger logger = Logger.getLogger(DepartureFetcher.class.getName());
+	
+	Map<Integer, List<DepartureBean>> cache = new TimeoutMap<Integer,List<DepartureBean>>(120 * 1000);
+	
 		
+	
+	public List<DepartureBean> cachedLookupDepartures(int stationID) throws Throwable {
 
-	public List<DepartureBean> lookupDepartures(int stationID) throws Exception {
+		List<DepartureBean> list = cache.get(stationID);
+		
+		if (list == null) {
+			list = lookupDepartures(stationID);
+			cache.put(stationID, list);
+		} else {
+			logger.info("Departure: Cache hit " + stationID); //remove before production
+		}
+		return list;
+	}
+		
+
+	public List<DepartureBean> lookupDepartures(int stationID) throws Throwable {
 		List<DepartureBean> departureList = new ArrayList<DepartureBean>();
 		
 		Connection conn = null;
@@ -54,52 +77,65 @@
 		return departureList;
 	}
 	
-	public List<DepartureBean> lookupDepartures(String stationcode, String type) throws Exception {
+	public List<DepartureBean> lookupDepartures(String stationcode, String type) throws Throwable {
 		
 		List<DepartureBean> departureList = new ArrayList<DepartureBean>();
 		
 	    final WebClient webClient = new WebClient();
-	    webClient.setTimeout(1000);
-	    webClient.setJavaScriptEnabled(false); 
+	    webClient.setTimeout(2500);
+	    webClient.setJavaScriptEnabled(false);
+	    	    	    
+	    String uri = "http://www.bane.dk/visStation.asp?ArtikelID=4275&W=" + type + "&S=" + stationcode;
+	    BanedkInvocation wrapper = new BanedkInvocation(webClient, uri);
+	    CircuitBreaker breaker = CircuitBreakerManager.getManager().getCircuitBreaker("banedk");
 	    
-	    final HtmlPage page = webClient.getPage("http://www.bane.dk/visStation.asp?ArtikelID=4275&W=" + type + "&S=" + stationcode);
+	    HtmlPage page = (HtmlPage) breaker.invoke(wrapper);
 	    
 	    HtmlElement table = page.getElementById("afgangtabel");
-	    DomNodeList<HtmlElement> tableRows =  table.getElementsByTagName("tr");
 	    
-	    for (HtmlElement currentRow : tableRows) {
-	    	String rowClass = currentRow.getAttribute("class");
-	    	if (rowClass != null && rowClass.toLowerCase().contains("station") ) {
-	    		DomNodeList<HtmlElement> fields = currentRow.getElementsByTagName("td");
-
-	    		DepartureBean departure = new DepartureBean();
-	    		
-	    		String time = fields.get(0).asText();
-	    		departure.setTime(time);
-	    		
-	    		int updated = extractUpdated( fields.get(1) );
-	    		departure.setUpdated(updated);
-	    		
-	    		String trainNumber = fields.get(2).asText();
-	    		departure.setTrainNumber(trainNumber);
-	    		
-	    		String destination = fields.get(3).asText();
-	    		departure.setDestination(destination);
-	    		
-	    		String origin = fields.get(4).asText();
-	    		departure.setOrigin(origin);
-	    		
-	    		String location = fields.get(5).asText();
-	    		departure.setLocation(location);
-	    		
-	    		String status = fields.get(6).asText();
-	    		departure.setStatus(status);
-	    		
-	    		String note = fields.get(7).asText();
-	    		departure.setNote(note);
-	    		
-	    		departureList.add(departure);
-	    	}
+	    if (table != null) {
+		    DomNodeList<HtmlElement> tableRows =  table.getElementsByTagName("tr");
+		    
+		    for (HtmlElement currentRow : tableRows) {
+		    	String rowClass = currentRow.getAttribute("class");
+		    	if (rowClass != null && rowClass.toLowerCase().contains("station") ) {
+		    		DomNodeList<HtmlElement> fields = currentRow.getElementsByTagName("td");
+	
+		    		DepartureBean departure = new DepartureBean();
+		    		
+		    		String time = fields.get(0).asText();
+		    		if (time.equals(""))
+		    			time = "0:00"; //Bane.dk bug work-around
+		    		departure.setTime(time);
+		    		
+		    		int updated = extractUpdated( fields.get(1) );
+		    		departure.setUpdated(updated);
+		    		
+		    		String trainNumber = fields.get(2).asText();
+		    		if (type.equalsIgnoreCase("S2")) //If it is S-train we need to extract the trainNumber 
+		    			trainNumber = trainNumber + " " + extractTrainNumber(fields.get(2));
+		    		departure.setTrainNumber(trainNumber);
+		    		
+		    		String destination = fields.get(3).asText();
+		    		departure.setDestination(destination);
+		    		
+		    		String origin = fields.get(4).asText();
+		    		departure.setOrigin(origin);
+		    		
+		    		String location = fields.get(5).asText();
+		    		departure.setLocation(location);
+		    		
+		    		String status = fields.get(6).asText();
+		    		departure.setStatus(status);
+		    		
+		    		String note = extractNote( fields.get(7) );
+		    		departure.setNote(note);
+		    		
+		    		departureList.add(departure);
+		    	}
+		    }
+	    } else {
+	    	logger.warning("No departures found for station=" + stationcode + ", type=" + type);
 	    }
 	    
 	    return departureList;
@@ -123,8 +159,37 @@
 		return updated;
 	}
 	
+	private String extractNote(HtmlElement noteTd) {
+		String note = noteTd.asText().trim();
+		
+		List<HtmlElement> elems = noteTd.getElementsByAttribute("span", "class", "bemtype");
+		if (elems.size() > 0 && note.charAt(note.length()-1) == 'i')
+			note = note.substring(0,note.length() -1 );
+
+		return note;
+	}
+	
+	private String extractTrainNumber(HtmlElement trainTd) {
+		String number = "";
+		HtmlElement anchorElement = trainTd.getElementsByTagName("a").get(0);
+		String href = anchorElement.getAttribute("href");
+		String argstring = href.substring( href.indexOf('?') + 1);
+		
+		String args[] = argstring.split("&");
+		for (String arg : args) {
+			String pair[] = arg.split("="); // Key=pair[0], Value=pair[1]
+			
+			if (pair[0].equalsIgnoreCase("TogNr"))
+				number = pair[1];
+		}
+		
+		
+		
+		return number;
+	}
+	
 	//test
-	public static void main(String args[]) throws Exception{
+	public static void main(String args[]) throws Throwable {
 		DepartureFetcher f = new DepartureFetcher();
 		List<DepartureBean> deps = f.lookupDepartures("AR", "FJRN");
 		for(DepartureBean d : deps) {