--- android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureFetcher.java 2010/09/08 12:31:55 1034 +++ android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureFetcher.java 2010/09/14 05:33:30 1046 @@ -79,6 +79,10 @@ departureBean.notifications.addAll(tempBean.notifications); } + if (departureBean.departureEntries.size() == 0) { + logger.info("No departures found for station " + stationID); + } + Collections.sort( departureBean.departureEntries ); @@ -169,7 +173,7 @@ String trainNumber = fields.get(2).text(); if (type == TrainType.STOG) //If it is S-train we need to extract the trainNumber - trainNumber = trainNumber + " " + extractTrainNumber(fields.get(2)); + trainNumber = trainNumber + " " + extractTrainNumberAzure(fields.get(2)); departure.setTrainNumber(trainNumber); String destination = fields.get(3).text(); @@ -214,14 +218,24 @@ return departureBean; } + + + public static String cleanText(String input) { + //apparently JSoup translates   characters on www.bane.dk to 0xA0 + return input.replace((char) 0xA0, (char)0x20).trim(); + } + public DepartureBean lookupDeparturesWwwSite(String stationcode, TrainType trainType, boolean arrival) throws Exception { DepartureBean departureBean = new DepartureBean(); String type = getTypeStringWww(trainType); + stationcode = URLEncoder.encode(stationcode, "ISO-8859-1"); + String uri = "http://www.bane.dk/visStation.asp?ArtikelID=4275&W=" + type + "&S=" + stationcode; + logger.info("URI:" + uri); JsoupInvocation wrapper = new JsoupInvocation( new URL(uri), replyTimeout); CircuitBreaker breaker = CircuitBreakerManager.getManager().getCircuitBreaker("banedk"); @@ -230,11 +244,26 @@ String tableName = arrival == false ? "afgangtabel" : "ankomsttabel"; Element table = page.getElementById(tableName); + + if (table != null) { Elements tableRows = table.getElementsByTag("tr"); + boolean passedTidsstreg = false; + boolean tidsstregExists = (table.getElementsByAttributeValue("class", "Tidsstreg").size() > 0); + for (Element currentRow : tableRows) { String rowClass = currentRow.attr("class"); + + if (tidsstregExists == true && passedTidsstreg == false) { + if (currentRow.getElementsByAttributeValue("class", "Tidsstreg").size() > 0) { + passedTidsstreg = true; + } else { + continue; + } + } + + if (rowClass != null && rowClass.toLowerCase().contains("station") ) { Elements fields = currentRow.getElementsByTag("td"); @@ -242,35 +271,32 @@ - String time = fields.get(0).getAllElements().get(2).text(); + String time = cleanText( fields.get(0).getAllElements().get(2).text() ); if (time.equals("")) time = "0:00"; //Bane.dk bug work-around departure.setTime(time); - logger.info("Time: " + time);// TODO: remove int updated = extractUpdated( fields.get(1) ); departure.setUpdated(updated); - logger.info("Updated: " + updated);// TODO: remove - String trainNumber = fields.get(2).text(); + String trainNumber = cleanText( fields.get(2).text() ); if (type.equalsIgnoreCase("S2")) //If it is S-train we need to extract the trainNumber - trainNumber = trainNumber + " " + extractTrainNumber(fields.get(2)); + trainNumber = trainNumber + " " + extractTrainNumberWww(fields.get(2)); departure.setTrainNumber(trainNumber); - logger.info("TrainNumber: " + trainNumber);// TODO: remove - String destination = fields.get(3).text(); + String destination = cleanText( fields.get(3).text() ); departure.setDestination(destination); - String origin = fields.get(4).text(); + String origin = cleanText( fields.get(4).text() ); departure.setOrigin(origin); - String location = fields.get(5).text(); + String location = cleanText( fields.get(5).text() ); departure.setLocation(location); - String status = fields.get(6).text().trim(); + String status = cleanText( fields.get(6).text() ); departure.setStatus(status); - String note = extractNote( fields.get(7) ); + String note = cleanText( extractNote( fields.get(7) ) ); departure.setNote(note); departure.setType(type); @@ -315,10 +341,10 @@ if (elems.size() > 0 && note.charAt(note.length()-1) == 'i') note = note.substring(0,note.length() -1 ); - return note; + return note.trim(); } - private String extractTrainNumber(Element trainTd) { + private String extractTrainNumberAzure(Element trainTd) { Element anchorElement = trainTd.getElementsByTag("a").get(0); String href = anchorElement.attr("href"); @@ -328,6 +354,25 @@ return number; } + private String extractTrainNumberWww(Element trainTd) { + String number = ""; + Element anchorElement = trainTd.getElementsByTag("a").get(0); + String href = anchorElement.attr("href"); + String argstring = href.substring( href.indexOf('?') + 1); + + String args[] = argstring.split("&"); + for (String arg : args) { + String pair[] = arg.split("="); // Key=pair[0], Value=pair[1] + + if (pair[0].equalsIgnoreCase("TogNr")) + number = pair[1]; + } + + + return number; + } + + //test /* public static void main(String args[]) throws Exception {