--- android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureFetcher.java 2010/09/16 15:30:27 1063 +++ android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureFetcher.java 2011/04/04 08:27:24 1252 @@ -26,6 +26,12 @@ REGIONAL } + enum FetchTrainType { + STOG, + REGIONAL, + BOTH + } + Logger logger = Logger.getLogger(DepartureFetcher.class.getName()); Map cache; @@ -44,14 +50,15 @@ - public DepartureBean cachedLookupDepartures(int stationID, boolean arrival) throws Exception { - final String key = "" + stationID + ":" + arrival; + public DepartureBean cachedLookupDepartures(int stationID, boolean arrival, FetchTrainType type) throws Exception { + + final String key = "" + stationID + ":" + arrival + ":" + type.toString(); DepartureBean departureBean = cache.get(key); if (departureBean == null) { - departureBean = lookupDepartures(stationID,arrival); + departureBean = lookupDepartures(stationID, arrival, type); cache.put(key, departureBean); } else { Statistics.getInstance().incrementDepartureCacheHits(); @@ -61,21 +68,21 @@ } - public DepartureBean lookupDepartures(int stationID, boolean arrival) throws Exception { + public DepartureBean lookupDepartures(int stationID, boolean arrival, FetchTrainType type) throws Exception { DepartureBean departureBean = new DepartureBean(); StationEntry station = stationDao.getById(stationID); departureBean.stationName = station.getName(); - - if (station.getRegional() != null) { + + if (station.getRegional() != null && (type == FetchTrainType.REGIONAL||type == FetchTrainType.BOTH) ) { DepartureBean tempBean = lookupDepartures(station.getRegional(), TrainType.REGIONAL, arrival); departureBean.entries.addAll( tempBean.entries ); departureBean.notifications.addAll(tempBean.notifications); } - if (station.getStrain() != null) { + if (station.getStrain() != null && (type == FetchTrainType.STOG||type == FetchTrainType.BOTH)) { DepartureBean tempBean = lookupDepartures(station.getStrain(), TrainType.STOG, arrival); departureBean.entries.addAll( tempBean.entries ); departureBean.notifications.addAll(tempBean.notifications); @@ -85,7 +92,9 @@ logger.info("No departures found for station " + stationID); } - Collections.sort( departureBean.entries ); + if (type == FetchTrainType.BOTH) { //if we have both S-tog and regional order by departure/arrival time + Collections.sort( departureBean.entries ); + } return departureBean; @@ -145,19 +154,19 @@ if (table != null) { Elements tableRows = table.getElementsByTag("tr"); - boolean tidsstregExists = (table.getElementsByAttributeValue("class", "Tidsstreg").size() > 0); - boolean passedTidsstreg = false; + //boolean tidsstregExists = (table.getElementsByAttributeValue("class", "Tidsstreg").size() > 0); + //boolean passedTidsstreg = false; for (Element currentRow : tableRows) { String rowClass = currentRow.attr("class"); - + /* if (tidsstregExists == true && passedTidsstreg == false) { if (currentRow.getElementsByAttributeValue("class", "Tidsstreg").size() > 0) { passedTidsstreg = true; } else { continue; } - } + }*/ if (rowClass != null && rowClass.toLowerCase().contains("station") ) { @@ -253,19 +262,19 @@ if (table != null) { Elements tableRows = table.getElementsByTag("tr"); - boolean passedTidsstreg = false; - boolean tidsstregExists = (table.getElementsByAttributeValue("class", "Tidsstreg").size() > 0); + //boolean passedTidsstreg = false; + //boolean tidsstregExists = (table.getElementsByAttributeValue("class", "Tidsstreg").size() > 0); for (Element currentRow : tableRows) { String rowClass = currentRow.attr("class"); - + /* if (tidsstregExists == true && passedTidsstreg == false) { if (currentRow.getElementsByAttributeValue("class", "Tidsstreg").size() > 0) { passedTidsstreg = true; } else { continue; } - } + }*/ if (rowClass != null && rowClass.toLowerCase().contains("station") ) {