--- android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureFetcher.java 2010/02/02 19:05:08 582 +++ android/TrainInfoService/src/dk/thoerup/traininfoservice/banedk/DepartureFetcher.java 2010/02/08 19:12:15 588 @@ -1,8 +1,5 @@ package dk.thoerup.traininfoservice.banedk; -import java.sql.Connection; -import java.sql.ResultSet; -import java.sql.Statement; import java.util.ArrayList; import java.util.Collections; import java.util.List; @@ -16,18 +13,22 @@ import dk.thoerup.circuitbreaker.CircuitBreaker; import dk.thoerup.circuitbreaker.CircuitBreakerManager; -import dk.thoerup.traininfoservice.DBConnection; +import dk.thoerup.traininfoservice.StationBean; +import dk.thoerup.traininfoservice.StationDAO; public class DepartureFetcher { Logger logger = Logger.getLogger(DepartureFetcher.class.getName()); - Map> cache = new TimeoutMap>(120 * 1000); + Map> cache; + + StationDAO stationDao = new StationDAO(); private boolean useTempSite; - public DepartureFetcher(boolean tempSite) { + public DepartureFetcher(boolean tempSite, int cacheTimeout) { useTempSite = tempSite; + cache = new TimeoutMap>(cacheTimeout); } @@ -50,37 +51,21 @@ public List lookupDepartures(int stationID) throws Exception { List departureList = new ArrayList(); - Connection conn = null; - try - { - conn = DBConnection.getConnection(); - - String SQL = "SELECT stationcode_fjrn, stationcode_stog FROM trainstations WHERE id=" + stationID; - Statement stmt = conn.createStatement(); - ResultSet rs = stmt.executeQuery(SQL); - - if (rs.next()) { - String code = rs.getString( 1 ); - if (! rs.wasNull() ) { - List list = lookupDepartures(code, "FJRN"); - departureList.addAll(list); - } - - code = rs.getString(2); - if (! rs.wasNull() ) { - List list = lookupDepartures(code, "S2"); - departureList.addAll(list); - } - Collections.sort( departureList ); - - } - - } finally { - if (conn != null && !conn.isClosed() ) { - conn.close(); - } + StationBean station = stationDao.getById(stationID); + + if (station.getRegional() != null) { + List list = lookupDepartures(station.getRegional(), "FJRN"); + departureList.addAll(list); } + if (station.getStrain() != null) { + List list = lookupDepartures(station.getStrain(), "S2"); + departureList.addAll(list); + } + + Collections.sort( departureList ); + + return departureList; } @@ -190,7 +175,7 @@ DepartureBean departure = new DepartureBean(); String time = fields.get(0).asText().trim(); - logger.info("time:" + time); + if (time.equals("")) time = "0:00"; //Bane.dk bug work-around departure.setTime(time);