--- android/TrainInfo/src/dk/thoerup/traininfo/provider/XmlDepartureProvider.java 2009/10/02 17:18:31 389 +++ android/TrainInfo/src/dk/thoerup/traininfo/provider/XmlDepartureProvider.java 2009/10/02 19:01:53 390 @@ -2,8 +2,6 @@ import java.io.StringReader; import java.util.ArrayList; -import java.util.Collections; -import java.util.HashMap; import java.util.List; import javax.xml.parsers.SAXParser; @@ -17,42 +15,41 @@ import android.util.Log; import dk.thoerup.traininfo.DepartureBean; +import dk.thoerup.traininfo.util.AndroidTimeoutCache; import dk.thoerup.traininfo.util.DownloadUtil; import dk.thoerup.traininfo.util.XmlUtil; public class XmlDepartureProvider extends DefaultHandler implements DepartureProvider { - final static long CACHE_TIMEOUT = 60*1000; + final static int CACHE_TIMEOUT = 60*1000; class CacheEntry { public long timestamp; public List departures; } - HashMap departureCache = new HashMap(); - ArrayList departures; + + AndroidTimeoutCache> departureCache = new AndroidTimeoutCache>(CACHE_TIMEOUT); + + List departures; DepartureBean tempDeparture; StringBuilder builder = new StringBuilder(512); @Override - public boolean lookupDepartures(int stationID) { - CacheEntry entry = departureCache.get(stationID); + public boolean lookupDepartures(int stationID) { boolean success; + + departures = departureCache.get(stationID); - long now = android.os.SystemClock.elapsedRealtime(); - if (entry == null || (entry.timestamp+CACHE_TIMEOUT) < now) { - + if (departures == null) { success = lookupDeparturesWorker(stationID); - if (success) { - entry = new CacheEntry(); - entry.timestamp = android.os.SystemClock.elapsedRealtime(); - entry.departures = departures; - - departureCache.put(stationID, entry); + if (success) { + departureCache.put(stationID, departures); } + } else { Log.i("XmlDepartureProvider", "cache hit !!!"); success = true; @@ -90,14 +87,13 @@ @Override public List getDepartures(int station) { - CacheEntry entry = departureCache.get(station); + List list = departureCache.get(station); - if (entry != null) { - return entry.departures; - } else { - return new ArrayList(); - } + if (list == null) { + list = new ArrayList(); + } + return list; } // this can be called several times fore the same text-node if there are many chardata / lines