--- android/TrainInfo/src/dk/thoerup/traininfo/provider/XmlDepartureProvider.java	2010/08/02 23:18:53	1006
+++ android/TrainInfo/src/dk/thoerup/traininfo/provider/XmlDepartureProvider.java	2010/08/03 06:12:10	1007
@@ -18,45 +18,43 @@
 import dk.thoerup.traininfo.util.DownloadUtil;
 import dk.thoerup.traininfo.util.XmlUtil;
 
-public class XmlDepartureProvider extends DefaultHandler implements DepartureProvider {
+public class XmlDepartureProvider implements DepartureProvider {
 
 	final static int CACHE_TIMEOUT = 60*1000;
 		
 	
 	AndroidTimeoutCache<String,DepartureBean> departureCache = new AndroidTimeoutCache<String,DepartureBean>(CACHE_TIMEOUT); 
 	
-	DepartureBean departures;
 		
 	
 	DepartureEntry tempDeparture;
 	StringBuilder builder = new StringBuilder(512);
 	
+
+	
 	@Override
-	public boolean lookupDepartures(int stationID, boolean arrival) {		
-		boolean success;
+	public DepartureBean lookupDepartures(int stationID, boolean arrival) {		
 		
 		String key = "" + stationID + ":" + arrival;
 		
-		departures = departureCache.get(key);
+		DepartureBean departures = departureCache.get(key);
 	
 		if (departures == null) {			
-			success = lookupDeparturesWorker(stationID, arrival);
+			departures = lookupDeparturesWorker(stationID, arrival);
 			
-			if (success) {			
+			if (departures != null) {			
 				departureCache.put(key, departures);
 			}
 			
 		} else {
 			Log.i("XmlDepartureProvider", "cache hit !!!");
-			success = true;
 		}		
 		
-		return success;
+		return departures;
 	}
 	
-	private boolean lookupDeparturesWorker(int stationID, boolean arrival) {
-		boolean success = false;
-		departures = new DepartureBean();
+	private DepartureBean lookupDeparturesWorker(int stationID, boolean arrival) {
+
 		try
 		{	
 			int iArrival = arrival ? 1 : 0;
@@ -70,73 +68,71 @@
             SAXParser sp = spf.newSAXParser();
             XMLReader xr = sp.getXMLReader();
 
-			xr.setContentHandler(this);
-			xr.setErrorHandler(this);
+            DepartureParser departureParser = new DepartureParser();
+			xr.setContentHandler(departureParser);
+			xr.setErrorHandler(departureParser);
 			xr.parse(source);
-			success = true;
+			
+			return departureParser.getDepartures();
 			
 		} catch (Exception e) {
 			Log.e("XmlDepartureProvider", "looupFunction", e);
-		}
-		return success;
+			return null;
+		}		
 	}
 	
-	@Override
-	public DepartureBean getDepartures(int station,boolean arrival) {
-		
-		String key = "" + station + ":" + arrival;
-		
-		DepartureBean bean = departureCache.get(key);
-		
-		if (bean == null) {			
-			bean = new DepartureBean();
-		} 
+
+	class DepartureParser extends DefaultHandler { 
 		
-		return bean;
-	}
-	
-	// this can be called several times fore the same text-node if there are many chardata / lines
-	@Override
-	public void characters (char ch[], int start, int length) 
-	{		
-		for (int i= start; i<start+length; i++)
-			builder.append(ch[i]);	
-	}
+		private DepartureBean departures = new DepartureBean(); 
+
+		public DepartureBean getDepartures() {
+			return departures;
+		}
 	
-	@Override
-	public void startElement (String uri, String name, String qName, Attributes atts)throws SAXException
-	{
-		if (name.equalsIgnoreCase("train"))
-			tempDeparture = new DepartureEntry();
+		// this can be called several times fore the same text-node if there are many chardata / lines
+		@Override
+		public void characters (char ch[], int start, int length) 
+		{		
+			for (int i= start; i<start+length; i++)
+				builder.append(ch[i]);	
+		}
 		
-		builder.setLength(0); //reset StringBuilder
-	}
-	
-	@Override
-	public void endElement (String uri, String name, String qName) throws SAXException
-	{
-		if (name.equals("train")) {			
-			departures.entries.add( tempDeparture );
-		} else if (name.equals("time")) {
-			tempDeparture.setTime(builder.toString().trim());
-		} else if (name.equals("updated")) {
-			tempDeparture.setLastUpdate(builder.toString().trim());
-		} else if (name.equals("trainnumber")) {
-			tempDeparture.setTrainNumber(builder.toString().trim());
-		} else if (name.equals("destination")) {
-			tempDeparture.setDestination(builder.toString().trim());
-		} else if (name.equals("origin")) {
-			tempDeparture.setOrigin(builder.toString().trim());
-		} else if (name.equals("location")) {
-			tempDeparture.setLocation(builder.toString().trim());
-		} else if (name.equals("status")) {
-			tempDeparture.setStatus(builder.toString().trim());
-		} else if (name.equals("note")) {
-			tempDeparture.setNote(builder.toString().trim());
-		} else if (name.equals("type")) {
-			tempDeparture.setType(builder.toString().trim());
-		} else if (name.equals("notification")) {
-			departures.notifications.add( builder.toString().trim() );
+		@Override
+		public void startElement (String uri, String name, String qName, Attributes atts)throws SAXException
+		{
+			if (name.equalsIgnoreCase("train"))
+				tempDeparture = new DepartureEntry();
+			
+			builder.setLength(0); //reset StringBuilder
+		}
+		
+		@Override
+		public void endElement (String uri, String name, String qName) throws SAXException
+		{
+			if (name.equals("train")) {			
+				departures.entries.add( tempDeparture );
+			} else if (name.equals("time")) {
+				tempDeparture.setTime(builder.toString().trim());
+			} else if (name.equals("updated")) {
+				tempDeparture.setLastUpdate(builder.toString().trim());
+			} else if (name.equals("trainnumber")) {
+				tempDeparture.setTrainNumber(builder.toString().trim());
+			} else if (name.equals("destination")) {
+				tempDeparture.setDestination(builder.toString().trim());
+			} else if (name.equals("origin")) {
+				tempDeparture.setOrigin(builder.toString().trim());
+			} else if (name.equals("location")) {
+				tempDeparture.setLocation(builder.toString().trim());
+			} else if (name.equals("status")) {
+				tempDeparture.setStatus(builder.toString().trim());
+			} else if (name.equals("note")) {
+				tempDeparture.setNote(builder.toString().trim());
+			} else if (name.equals("type")) {
+				tempDeparture.setType(builder.toString().trim());
+			} else if (name.equals("notification")) {
+				departures.notifications.add( builder.toString().trim() );
+			}
 		}
 	}
 }